test: add eslint rule to verify assertion input#20718
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
test: add eslint rule to verify assertion input#20718BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
The input for `assert.deepStrictEqual` and similar expect the actual input first and the expected input as second argument. This verifies that this is actually done correct in our tests. This is important so the possible error message actually makes sense.
nodejs-github-bot
added
dont-land-on-v4.x
node-api
Member
Author
Member
|
@BridgeAR If the |
Trott
approved these changes
May 14, 2018
trivikr
approved these changes
May 15, 2018
Member
Author
|
@Trott that is a good idea even though I personally think we should try to have a bit more "challenging" tasks in code and learn. |
BridgeAR
added
the
author ready
jasnell
approved these changes
May 15, 2018
Member
Author
|
Landed in dd9d32f |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 18, 2018
The input for `assert.deepStrictEqual` and similar expect the actual input first and the expected input as second argument. This verifies that this is actually done correct in our tests. This is important so the possible error message actually makes sense. PR-URL: nodejs#20718 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
The input for `assert.deepStrictEqual` and similar expect the actual input first and the expected input as second argument. This verifies that this is actually done correct in our tests. This is important so the possible error message actually makes sense. PR-URL: #20718 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input for
assert.deepStrictEqualand similar expect the actualinput first and the expected input as second argument. This verifies
that this is actually done correct in our tests.
This is important so the possible error message actually makes sense.
assert.strictEqualproduces around 600 errors and I am not sure if we really want to activate such a rule for them right now even though the input is wrong. Any opinions?Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes